summaryrefslogtreecommitdiff
path: root/drivers/usb/host/ehci-exynos.c
diff options
context:
space:
mode:
authorTang Bin <tangbin@cmss.chinamobile.com>2020-06-02 14:47:08 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-06-18 11:40:57 +0300
commit44ed240d62736ad29943ec01e41e194b96f7c5e9 (patch)
tree08b5247596a11be0b5acbdccd2a8b95d78408bd7 /drivers/usb/host/ehci-exynos.c
parent130206a88683d859f63ed6d4a56ab5c2b4930c8e (diff)
downloadlinux-44ed240d62736ad29943ec01e41e194b96f7c5e9.tar.xz
usb: host: ehci-exynos: Fix error check in exynos_ehci_probe()
If the function platform_get_irq() failed, the negative value returned will not be detected here. So fix error handling in exynos_ehci_probe(). And when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Fixes: 1bcc5aa87f04 ("USB: Add initial S5P EHCI driver") Cc: stable <stable@vger.kernel.org> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Link: https://lore.kernel.org/r/20200602114708.28620-1-tangbin@cmss.chinamobile.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host/ehci-exynos.c')
-rw-r--r--drivers/usb/host/ehci-exynos.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index a4e9abcbdc4f..1a9b7572e17f 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -203,9 +203,8 @@ static int exynos_ehci_probe(struct platform_device *pdev)
hcd->rsrc_len = resource_size(res);
irq = platform_get_irq(pdev, 0);
- if (!irq) {
- dev_err(&pdev->dev, "Failed to get IRQ\n");
- err = -ENODEV;
+ if (irq < 0) {
+ err = irq;
goto fail_io;
}