summaryrefslogtreecommitdiff
path: root/drivers/usb/host/ehci-exynos.c
diff options
context:
space:
mode:
authorVivek Gautam <gautam.vivek@samsung.com>2014-10-06 10:21:10 +0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-11-04 02:34:00 +0300
commit6d40500ac9b69b78dace3a498bc1690200682789 (patch)
tree34add65ecb4a73fa431835990e3340991fcef976 /drivers/usb/host/ehci-exynos.c
parent61fbe96c8b131dcf246030c72dfe97a2cbfb247b (diff)
downloadlinux-6d40500ac9b69b78dace3a498bc1690200682789.tar.xz
usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs
On enabling CONFIG_OF_SELFTEST which enables CONFIG_OF_DYNAMIC, we found out that while getting PHYs for the controller we were doing an extra of_node_put on the child node in our routines - exynos_e/ohci_get_phy(). This child is however already put by of_get_next_available_child() which does a of_node_put() on the "prev" node. So there's no point in putting the same node again in our routine. Reported-by: Daniel Drake <drake@endlessm.com> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host/ehci-exynos.c')
-rw-r--r--drivers/usb/host/ehci-exynos.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index 7189f2e32ac2..1b726bfdcbea 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -74,7 +74,6 @@ static int exynos_ehci_get_phy(struct device *dev,
phy = devm_of_phy_get(dev, child, NULL);
exynos_ehci->phy[phy_number] = phy;
- of_node_put(child);
if (IS_ERR(phy)) {
ret = PTR_ERR(phy);
if (ret == -EPROBE_DEFER) {