summaryrefslogtreecommitdiff
path: root/drivers/usb
diff options
context:
space:
mode:
authorjidong xiao <jidong.xiao@gmail.com>2007-09-13 20:08:51 +0400
committerGreg Kroah-Hartman <gregkh@suse.de>2007-10-13 01:55:27 +0400
commit403fae78d7388876b96fbe30ccf2cb551c49ae5a (patch)
tree49b1dd0cfd74f676bca9c4273de320ca137e2444 /drivers/usb
parented6590a861a16276db34ee626375fa79f3369ac3 (diff)
downloadlinux-403fae78d7388876b96fbe30ccf2cb551c49ae5a.tar.xz
USB: fix limited_power setting mistake in hub.c
This patch (jx001) fixes a variable assignment mistake in hub driver. limited_power should be set to 0 if the hub is self-powered,and 1 if the hub is bus-powered. However, the effect of the code was exactly opposite to the spec's statement for the Local Power Source field. The spec says, this field is 1 meaning Local power supply lost while this field is 0 indicating Local power supply good.(This statement is very confusing.) So this patch switchs the 0 and 1. Signed-off-by: Jason Xiao <jidong.xiao@gmail.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/core/hub.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 691acf2223c2..481dca641ea2 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -2818,9 +2818,9 @@ static void hub_events(void)
clear_hub_feature(hdev, C_HUB_LOCAL_POWER);
if (hubstatus & HUB_STATUS_LOCAL_POWER)
/* FIXME: Is this always true? */
- hub->limited_power = 0;
- else
hub->limited_power = 1;
+ else
+ hub->limited_power = 0;
}
if (hubchange & HUB_CHANGE_OVERCURRENT) {
dev_dbg (hub_dev, "overcurrent change\n");