diff options
| author | Logan Gunthorpe <logang@deltatee.com> | 2020-03-21 14:25:45 +0300 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2020-03-21 18:00:20 +0300 |
| commit | efbdc769601f4d50018bf7ca50fc9f7c67392ece (patch) | |
| tree | c8b97ed56eb65fd4c9f94ad5b88f043fe1095a81 /drivers/usb | |
| parent | f6f48e18040402136874a6a71611e081b4d0788a (diff) | |
| download | linux-efbdc769601f4d50018bf7ca50fc9f7c67392ece.tar.xz | |
PCI/switchtec: Fix init_completion race condition with poll_wait()
The call to init_completion() in mrpc_queue_cmd() can theoretically
race with the call to poll_wait() in switchtec_dev_poll().
poll() write()
switchtec_dev_poll() switchtec_dev_write()
poll_wait(&s->comp.wait); mrpc_queue_cmd()
init_completion(&s->comp)
init_waitqueue_head(&s->comp.wait)
To my knowledge, no one has hit this bug.
Fix this by using reinit_completion() instead of init_completion() in
mrpc_queue_cmd().
Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver")
Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lkml.kernel.org/r/20200313183608.2646-1-logang@deltatee.com
Diffstat (limited to 'drivers/usb')
0 files changed, 0 insertions, 0 deletions