summaryrefslogtreecommitdiff
path: root/drivers/vdpa/ifcvf
diff options
context:
space:
mode:
authorTanmay Bhushan <007047221b@gmail.com>2022-12-28 00:02:16 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-02-22 14:59:42 +0300
commit5d2cc32c1c10bd889125d2adc16a6bc3338dcd3e (patch)
tree79037b0ed85e423b1ad721e2e7d76ea54d878a45 /drivers/vdpa/ifcvf
parent2ad95cb1af7ada2a7a3a558352cbb7a7ab160e43 (diff)
downloadlinux-5d2cc32c1c10bd889125d2adc16a6bc3338dcd3e.tar.xz
vdpa: ifcvf: Do proper cleanup if IFCVF init fails
[ Upstream commit 6b04456e248761cf68f562f2fd7c04e591fcac94 ] ifcvf_mgmt_dev leaks memory if it is not freed before returning. Call is made to correct return statement so memory does not leak. ifcvf_init_hw does not take care of this so it is needed to do it here. Signed-off-by: Tanmay Bhushan <007047221b@gmail.com> Message-Id: <772e9fe133f21fa78fb98a2ebe8969efbbd58e3c.camel@gmail.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Acked-by: Zhu Lingshan <lingshan.zhu@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/vdpa/ifcvf')
-rw-r--r--drivers/vdpa/ifcvf/ifcvf_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
index f9c0044c6442..44b29289aa19 100644
--- a/drivers/vdpa/ifcvf/ifcvf_main.c
+++ b/drivers/vdpa/ifcvf/ifcvf_main.c
@@ -849,7 +849,7 @@ static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
ret = ifcvf_init_hw(vf, pdev);
if (ret) {
IFCVF_ERR(pdev, "Failed to init IFCVF hw\n");
- return ret;
+ goto err;
}
for (i = 0; i < vf->nr_vring; i++)