summaryrefslogtreecommitdiff
path: root/drivers/vdpa/vdpa_user
diff options
context:
space:
mode:
authorXie Yongji <xieyongji@bytedance.com>2021-09-06 17:21:58 +0300
committerMichael S. Tsirkin <mst@redhat.com>2021-09-15 01:10:43 +0300
commit7bb5fb207334758ce6ee84345d6f08e4fb284fe6 (patch)
tree8d5e6f2172db7f33f1e6a9ff50ef987b0d099a75 /drivers/vdpa/vdpa_user
parent6243e3c78ace66d337a1e43b60a1aa8f5b61bd72 (diff)
downloadlinux-7bb5fb207334758ce6ee84345d6f08e4fb284fe6.tar.xz
vduse: Cleanup the old kernel states after reset failure
We should cleanup the old kernel states e.g. interrupt callback no matter whether the userspace handle the reset correctly or not since virtio-vdpa can't handle the reset failure now. Otherwise, the old state might be used after reset which might break something, e.g. the old interrupt callback might be triggered by userspace after reset, which can break the virtio device driver. Signed-off-by: Xie Yongji <xieyongji@bytedance.com> Link: https://lore.kernel.org/r/20210906142158.181-1-xieyongji@bytedance.com Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'drivers/vdpa/vdpa_user')
-rw-r--r--drivers/vdpa/vdpa_user/vduse_dev.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index e36287feac0e..26e3d90d1e7c 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -665,13 +665,11 @@ static void vduse_vdpa_set_config(struct vdpa_device *vdpa, unsigned int offset,
static int vduse_vdpa_reset(struct vdpa_device *vdpa)
{
struct vduse_dev *dev = vdpa_to_vduse(vdpa);
-
- if (vduse_dev_set_status(dev, 0))
- return -EIO;
+ int ret = vduse_dev_set_status(dev, 0);
vduse_dev_reset(dev);
- return 0;
+ return ret;
}
static u32 vduse_vdpa_get_generation(struct vdpa_device *vdpa)