diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-08 10:39:44 +0300 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-03-16 18:08:37 +0300 |
| commit | 20c111d2e18c7318a9f2ae815c84ea0a9218317e (patch) | |
| tree | 899951ac2043cef269b1b15d629819a09cb6f854 /drivers/video/backlight | |
| parent | ea379bc80231c8a86730f854e436eff19a729950 (diff) | |
| download | linux-20c111d2e18c7318a9f2ae815c84ea0a9218317e.tar.xz | |
backlight: rt4831-backlight: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230308073945.2336302-13-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/video/backlight')
| -rw-r--r-- | drivers/video/backlight/rt4831-backlight.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/video/backlight/rt4831-backlight.c b/drivers/video/backlight/rt4831-backlight.c index eb8c59e8713f..7d1af4c2ca67 100644 --- a/drivers/video/backlight/rt4831-backlight.c +++ b/drivers/video/backlight/rt4831-backlight.c @@ -203,15 +203,13 @@ static int rt4831_bl_probe(struct platform_device *pdev) return 0; } -static int rt4831_bl_remove(struct platform_device *pdev) +static void rt4831_bl_remove(struct platform_device *pdev) { struct rt4831_priv *priv = platform_get_drvdata(pdev); struct backlight_device *bl_dev = priv->bl; bl_dev->props.brightness = 0; backlight_update_status(priv->bl); - - return 0; } static const struct of_device_id __maybe_unused rt4831_bl_of_match[] = { @@ -226,7 +224,7 @@ static struct platform_driver rt4831_bl_driver = { .of_match_table = rt4831_bl_of_match, }, .probe = rt4831_bl_probe, - .remove = rt4831_bl_remove, + .remove_new = rt4831_bl_remove, }; module_platform_driver(rt4831_bl_driver); |