summaryrefslogtreecommitdiff
path: root/drivers/video/fbdev/atmel_lcdfb.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2014-08-07 00:12:18 +0400
committerTomi Valkeinen <tomi.valkeinen@ti.com>2014-08-26 14:04:15 +0400
commit6c131850eca653344c41d68ce87f3ab5a89af89e (patch)
tree758e66de85080a903f19f5de78aa7562ca18df58 /drivers/video/fbdev/atmel_lcdfb.c
parent2b6c53b1504865728a6dfad3e720918a2f89f3a5 (diff)
downloadlinux-6c131850eca653344c41d68ce87f3ab5a89af89e.tar.xz
drivers: video: fbdev: atmel_lcdfb.c: fix error return code
Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video/fbdev/atmel_lcdfb.c')
-rw-r--r--drivers/video/fbdev/atmel_lcdfb.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
index 92640d46770a..1d8bdb92939b 100644
--- a/drivers/video/fbdev/atmel_lcdfb.c
+++ b/drivers/video/fbdev/atmel_lcdfb.c
@@ -1102,12 +1102,14 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)
timings = of_get_display_timings(display_np);
if (!timings) {
dev_err(dev, "failed to get display timings\n");
+ ret = -EINVAL;
goto put_display_node;
}
timings_np = of_find_node_by_name(display_np, "display-timings");
if (!timings_np) {
dev_err(dev, "failed to find display-timings node\n");
+ ret = -ENODEV;
goto put_display_node;
}