summaryrefslogtreecommitdiff
path: root/drivers/video/fbdev/aty/atyfb.h
diff options
context:
space:
mode:
authorMikulas Patocka <mpatocka@redhat.com>2018-10-08 13:57:35 +0300
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2018-10-08 13:57:35 +0300
commitc09bcc91bb94ed91f1391bffcbe294963d605732 (patch)
tree5c86dce4ed96c1e3692a1f5e700ba5b611ae29d0 /drivers/video/fbdev/aty/atyfb.h
parent3c6c6a7878d00a3ac997a779c5b9861ff25dfcc8 (diff)
downloadlinux-c09bcc91bb94ed91f1391bffcbe294963d605732.tar.xz
mach64: fix image corruption due to reading accelerator registers
Reading the registers without waiting for engine idle returns unpredictable values. These unpredictable values result in display corruption - if atyfb_imageblit reads the content of DP_PIX_WIDTH with the bit DP_HOST_TRIPLE_EN set (from previous invocation), the driver would never ever clear the bit, resulting in display corruption. We don't want to wait for idle because it would degrade performance, so this patch modifies the driver so that it never reads accelerator registers. HOST_CNTL doesn't have to be read, we can just write it with HOST_BYTE_ALIGN because no other part of the driver cares if HOST_BYTE_ALIGN is set. DP_PIX_WIDTH is written in the functions atyfb_copyarea and atyfb_fillrect with the default value and in atyfb_imageblit with the value set according to the source image data. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Reviewed-by: Ville Syrjälä <syrjala@sci.fi> Cc: stable@vger.kernel.org Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Diffstat (limited to 'drivers/video/fbdev/aty/atyfb.h')
0 files changed, 0 insertions, 0 deletions