summaryrefslogtreecommitdiff
path: root/drivers/video
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-11-17 19:21:48 +0300
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2017-11-17 19:21:48 +0300
commit5fa1f45de8fd697d9f23050e20dd65c0998e6107 (patch)
tree1228e9336961695239c00e577e6492afad26b353 /drivers/video
parentd447ebf9c77b16effd8aca114d7d281639e3f77f (diff)
downloadlinux-5fa1f45de8fd697d9f23050e20dd65c0998e6107.tar.xz
video: fbdev: sm501fb: fix potential null pointer dereference on fbi
The pointer fbi is dereferenced with par = fbi->par before there is a null check on fbi, hence there is a potential null pointer dereference on a null par. Fix this by moving the dereference after the null pointer check. Detected by CoverityScan, CID#1461301 ("Dereference before null check") Signed-off-by: Colin Ian King <colin.king@canonical.com> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/fbdev/sm501fb.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index 8d4fdb373299..6f0a19501c6a 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -2100,11 +2100,12 @@ static int sm501fb_suspend_fb(struct sm501fb_info *info,
enum sm501_controller head)
{
struct fb_info *fbi = info->fb[head];
- struct sm501fb_par *par = fbi->par;
+ struct sm501fb_par *par;
if (!fbi)
return 0;
+ par = fbi->par;
if (par->screen.size == 0)
return 0;
@@ -2150,11 +2151,12 @@ static void sm501fb_resume_fb(struct sm501fb_info *info,
enum sm501_controller head)
{
struct fb_info *fbi = info->fb[head];
- struct sm501fb_par *par = fbi->par;
+ struct sm501fb_par *par;
if (!fbi)
return;
+ par = fbi->par;
if (par->screen.size == 0)
return;