diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-09-26 17:20:59 +0300 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-02-22 13:54:59 +0300 |
| commit | 81bc9eada9e75d011d055505a7a30b760af0455f (patch) | |
| tree | 8392c658c8c2ae8d45d04987ccdacbbe161a7f06 /drivers/video | |
| parent | 3755b46a1bf47a6778f4ce33def1e6122796f57c (diff) | |
| download | linux-81bc9eada9e75d011d055505a7a30b760af0455f.tar.xz | |
backlight: ktd253: Switch to use dev_err_probe() helper
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20220926142059.2294282-1-yangyingliang@huawei.com
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/backlight/ktd253-backlight.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/video/backlight/ktd253-backlight.c b/drivers/video/backlight/ktd253-backlight.c index 37aa5a669530..d7d43454f64a 100644 --- a/drivers/video/backlight/ktd253-backlight.c +++ b/drivers/video/backlight/ktd253-backlight.c @@ -173,12 +173,9 @@ static int ktd253_backlight_probe(struct platform_device *pdev) } ktd253->gpiod = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); - if (IS_ERR(ktd253->gpiod)) { - ret = PTR_ERR(ktd253->gpiod); - if (ret != -EPROBE_DEFER) - dev_err(dev, "gpio line missing or invalid.\n"); - return ret; - } + if (IS_ERR(ktd253->gpiod)) + return dev_err_probe(dev, PTR_ERR(ktd253->gpiod), + "gpio line missing or invalid.\n"); gpiod_set_consumer_name(ktd253->gpiod, dev_name(dev)); /* Bring backlight to a known off state */ msleep(KTD253_T_OFF_MS); |