summaryrefslogtreecommitdiff
path: root/drivers/watchdog/exar_wdt.c
diff options
context:
space:
mode:
authorManank Patel <pmanank200502@gmail.com>2022-10-13 12:52:58 +0300
committerWim Van Sebroeck <wim@linux-watchdog.org>2022-10-19 20:49:47 +0300
commit82ebbe65d781064cfb0a6a8af221a9cebcaaac9e (patch)
tree01b137546a2f8c0b7d9d858bc0d13a8cf69fa8c8 /drivers/watchdog/exar_wdt.c
parent097a4a1612389c31d2c4b95dfa816b91212d7f54 (diff)
downloadlinux-82ebbe65d781064cfb0a6a8af221a9cebcaaac9e.tar.xz
drivers: watchdog: exar_wdt.c fix use after free
fix use after free by storing the result of PTR_ERR(n->pdev) to a local variable before returning. Signed-off-by: Manank Patel <pmanank200502@gmail.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20221013095258.1424967-1-pmanank200502@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Diffstat (limited to 'drivers/watchdog/exar_wdt.c')
-rw-r--r--drivers/watchdog/exar_wdt.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/watchdog/exar_wdt.c b/drivers/watchdog/exar_wdt.c
index 35058d8b21bc..7c61ff343271 100644
--- a/drivers/watchdog/exar_wdt.c
+++ b/drivers/watchdog/exar_wdt.c
@@ -355,8 +355,10 @@ static int __init exar_wdt_register(struct wdt_priv *priv, const int idx)
&priv->wdt_res, 1,
priv, sizeof(*priv));
if (IS_ERR(n->pdev)) {
+ int err = PTR_ERR(n->pdev);
+
kfree(n);
- return PTR_ERR(n->pdev);
+ return err;
}
list_add_tail(&n->list, &pdev_list);