summaryrefslogtreecommitdiff
path: root/drivers/watchdog/wm8350_wdt.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-05-27 16:32:24 +0400
committerWim Van Sebroeck <wim@iguana.be>2010-06-07 19:55:03 +0400
commitcfca31ce789963c0dd6ca2e9cc13b90cc2802fbd (patch)
tree9e070bff1b5c69a126b9c5dfbd1b5dd11df2263e /drivers/watchdog/wm8350_wdt.c
parent386f40c86d6c8d5b717ef20620af1a750d0dacb4 (diff)
downloadlinux-cfca31ce789963c0dd6ca2e9cc13b90cc2802fbd.tar.xz
[PATCH 2/11] drivers/watchdog: Eliminate a NULL pointer dereference
At the point of the call to dev_err, wm8350 is NULL. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ expression E,E1; identifier f; statement S1,S2,S3; @@ if ((E == NULL && ...) || ...) { ... when != if (...) S1 else S2 when != E = E1 * E->f ... when any return ...; } else S3 // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog/wm8350_wdt.c')
-rw-r--r--drivers/watchdog/wm8350_wdt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/watchdog/wm8350_wdt.c b/drivers/watchdog/wm8350_wdt.c
index 89dd7b035295..b68d928c8f90 100644
--- a/drivers/watchdog/wm8350_wdt.c
+++ b/drivers/watchdog/wm8350_wdt.c
@@ -284,7 +284,7 @@ static int __devinit wm8350_wdt_probe(struct platform_device *pdev)
struct wm8350 *wm8350 = platform_get_drvdata(pdev);
if (!wm8350) {
- dev_err(wm8350->dev, "No driver data supplied\n");
+ pr_err("No driver data supplied\n");
return -ENODEV;
}