summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorYang Li <yang.lee@linux.alibaba.com>2023-07-27 03:57:41 +0300
committerDavid S. Miller <davem@davemloft.net>2023-07-29 18:58:00 +0300
commit64a37272fa5fb2d951ebd1a96fd42b045d64924c (patch)
tree8eaa211ae0e1c23791314520ed0b532e89b5eaf9 /drivers
parent88efedf517e69a4b12e4dd40c44c2e298f53fa83 (diff)
downloadlinux-64a37272fa5fb2d951ebd1a96fd42b045d64924c.tar.xz
team: Remove NULL check before dev_{put, hold}
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning: ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/team/team.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index d3dc22509ea5..bc50fc3f6913 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info)
ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]);
dev = dev_get_by_index(net, ifindex);
if (!dev || dev->netdev_ops != &team_netdev_ops) {
- if (dev)
- dev_put(dev);
+ dev_put(dev);
return NULL;
}