summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorGUO Zihua <guozihua@huawei.com>2022-11-22 11:50:46 +0300
committerAlexandre Belloni <alexandre.belloni@bootlin.com>2022-12-16 01:34:31 +0300
commit55d5a86618d3b1a768bce01882b74cbbd2651975 (patch)
treee4b439b8a9dfeacd74007ca766c334588e8ef46e /drivers
parent3bb23f1f9d5a66e23f643b2318a64d88f2585c8e (diff)
downloadlinux-55d5a86618d3b1a768bce01882b74cbbd2651975.tar.xz
rtc: mxc_v2: Add missing clk_disable_unprepare()
The call to clk_disable_unprepare() is left out in the error handling of devm_rtc_allocate_device. Add it back. Fixes: 5490a1e018a4 ("rtc: mxc_v2: fix possible race condition") Signed-off-by: GUO Zihua <guozihua@huawei.com> Link: https://lore.kernel.org/r/20221122085046.21689-1-guozihua@huawei.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/rtc/rtc-mxc_v2.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-mxc_v2.c b/drivers/rtc/rtc-mxc_v2.c
index 5e0383401629..f6d2ad91ff7a 100644
--- a/drivers/rtc/rtc-mxc_v2.c
+++ b/drivers/rtc/rtc-mxc_v2.c
@@ -336,8 +336,10 @@ static int mxc_rtc_probe(struct platform_device *pdev)
}
pdata->rtc = devm_rtc_allocate_device(&pdev->dev);
- if (IS_ERR(pdata->rtc))
+ if (IS_ERR(pdata->rtc)) {
+ clk_disable_unprepare(pdata->clk);
return PTR_ERR(pdata->rtc);
+ }
pdata->rtc->ops = &mxc_rtc_ops;
pdata->rtc->range_max = U32_MAX;