diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-12-13 15:27:04 +0300 |
---|---|---|
committer | Jiri Slaby <jslaby@suse.cz> | 2017-01-26 19:40:16 +0300 |
commit | 7d91bd7b2ebde09846fa6dc2af292212b0f91d72 (patch) | |
tree | 007cc27dcc4512ebb64d574086608d361857dc75 /drivers | |
parent | 383591b85c75182128609049f11d72c22b6a0918 (diff) | |
download | linux-7d91bd7b2ebde09846fa6dc2af292212b0f91d72.tar.xz |
target/iscsi: Fix double free in lio_target_tiqn_addtpg()
commit a91918cd3ea11f91c68e08e1e8ce1b560447a80e upstream.
This iscsit_tpg_add_portal_group() function is only called from
lio_target_tiqn_addtpg(). Both functions free the "tpg" pointer on
error so it's a double free bug. The memory is allocated in the caller
so it should be freed in the caller and not here.
Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
[ bvanassche: Added "Fix" at start of patch title ]
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/target/iscsi/iscsi_target_tpg.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/target/iscsi/iscsi_target_tpg.c b/drivers/target/iscsi/iscsi_target_tpg.c index b713d63a86f7..ed4ea4ef1420 100644 --- a/drivers/target/iscsi/iscsi_target_tpg.c +++ b/drivers/target/iscsi/iscsi_target_tpg.c @@ -258,7 +258,6 @@ err_out: iscsi_release_param_list(tpg->param_list); tpg->param_list = NULL; } - kfree(tpg); return -ENOMEM; } |