summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorWei Fang <wei.fang@nxp.com>2023-05-04 11:03:59 +0300
committerDavid S. Miller <davem@davemloft.net>2023-05-05 11:32:36 +0300
commit299efdc2380aac588557f4d0b2ce7bee05bd0cf2 (patch)
treeb3710aa5f3b0d152c12e2e8e21bdbb006fb553be /drivers
parentc00ce5470a8adeaf681865836085f72633c00a7e (diff)
downloadlinux-299efdc2380aac588557f4d0b2ce7bee05bd0cf2.tar.xz
net: enetc: check the index of the SFI rather than the handle
We should check whether the current SFI (Stream Filter Instance) table is full before creating a new SFI entry. However, the previous logic checks the handle by mistake and might lead to unpredictable behavior. Fixes: 888ae5a3952b ("net: enetc: add tc flower psfp offload driver") Signed-off-by: Wei Fang <wei.fang@nxp.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/ethernet/freescale/enetc/enetc_qos.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
index 130ebf6853e6..83c27bbbc6ed 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -1247,7 +1247,7 @@ static int enetc_psfp_parse_clsflower(struct enetc_ndev_priv *priv,
int index;
index = enetc_get_free_index(priv);
- if (sfi->handle < 0) {
+ if (index < 0) {
NL_SET_ERR_MSG_MOD(extack, "No Stream Filter resource!");
err = -ENOSPC;
goto free_fmi;