diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-01-08 08:04:30 +0300 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-23 00:09:49 +0300 |
| commit | c82ed3047b8875b07b19e6e287c48f27a37b756f (patch) | |
| tree | 1d873ca336d0d60d59030474baa89d3412692a6d /fs/bcachefs/btree_iter.c | |
| parent | ee94c413a7ef5f10a2768826b2e576981990c4b8 (diff) | |
| download | linux-c82ed3047b8875b07b19e6e287c48f27a37b756f.tar.xz | |
bcachefs: Fix bch2_btree_path_traverse_all()
We need to take a ref on a path while we're traversing it: this fixes a
bug with paths getting reused while being traversed, in the key cache
fill code.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/btree_iter.c')
| -rw-r--r-- | fs/bcachefs/btree_iter.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c index 398db0faa816..31733c239746 100644 --- a/fs/bcachefs/btree_iter.c +++ b/fs/bcachefs/btree_iter.c @@ -999,7 +999,10 @@ retry_all: * the same position: */ if (path->uptodate) { + __btree_path_get(path, false); ret = btree_path_traverse_one(trans, path, 0, _THIS_IP_); + __btree_path_put(path, false); + if (bch2_err_matches(ret, BCH_ERR_transaction_restart) || ret == -ENOMEM) goto retry_all; |