summaryrefslogtreecommitdiff
path: root/fs/bcachefs/reflink.c
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@gmail.com>2021-05-17 07:08:06 +0300
committerKent Overstreet <kent.overstreet@linux.dev>2023-10-23 00:09:03 +0300
commit2e8f9d23cbc75a1d45506186da8c7a5c1605b622 (patch)
treeb38a53d37fdec149356b6f503c3e3efd3e5a9d3a /fs/bcachefs/reflink.c
parent2cd0563461b68b895bd683e89ad70f3975e98e85 (diff)
downloadlinux-2e8f9d23cbc75a1d45506186da8c7a5c1605b622.tar.xz
bcachefs: Make sure to pass a disk reservation to bch2_extent_update()
It's needed when we split an existing compressed extent - we get a null ptr deref without it. Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Diffstat (limited to 'fs/bcachefs/reflink.c')
-rw-r--r--fs/bcachefs/reflink.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/bcachefs/reflink.c b/fs/bcachefs/reflink.c
index 0978ad92614c..405a194d10e5 100644
--- a/fs/bcachefs/reflink.c
+++ b/fs/bcachefs/reflink.c
@@ -2,6 +2,7 @@
#include "bcachefs.h"
#include "bkey_buf.h"
#include "btree_update.h"
+#include "buckets.h"
#include "extents.h"
#include "inode.h"
#include "io.h"
@@ -224,6 +225,8 @@ s64 bch2_remap_range(struct bch_fs *c,
BTREE_ITER_INTENT);
while (ret == 0 || ret == -EINTR) {
+ struct disk_reservation disk_res = { 0 };
+
bch2_trans_begin(&trans);
if (fatal_signal_pending(current)) {
@@ -287,8 +290,9 @@ s64 bch2_remap_range(struct bch_fs *c,
dst_end.offset - dst_iter->pos.offset));
ret = bch2_extent_update(&trans, dst_iter, new_dst.k,
- NULL, journal_seq,
+ &disk_res, journal_seq,
new_i_size, i_sectors_delta);
+ bch2_disk_reservation_put(c, &disk_res);
if (ret)
continue;