diff options
author | Stefan Haberland <sth@linux.ibm.com> | 2019-08-01 14:06:30 +0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-08-02 05:46:14 +0300 |
commit | 41995342b40c418a47603e1321256d2c4a2ed0fb (patch) | |
tree | 3af80c31a5f01521519796f7e33b77bfcbe7da17 /fs/block_dev.c | |
parent | 0eb6ddfb865c7d7ec05cb330050671363515e67f (diff) | |
download | linux-41995342b40c418a47603e1321256d2c4a2ed0fb.tar.xz |
s390/dasd: fix endless loop after read unit address configuration
After getting a storage server event that causes the DASD device driver
to update its unit address configuration during a device shutdown there is
the possibility of an endless loop in the device driver.
In the system log there will be ongoing DASD error messages with RC: -19.
The reason is that the loop starting the ruac request only terminates when
the retry counter is decreased to 0. But in the sleep_on function there are
early exit paths that do not decrease the retry counter.
Prevent an endless loop by handling those cases separately.
Remove the unnecessary do..while loop since the sleep_on function takes
care of retries by itself.
Fixes: 8e09f21574ea ("[S390] dasd: add hyper PAV support to DASD device driver, part 1")
Cc: stable@vger.kernel.org # 2.6.25+
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/block_dev.c')
0 files changed, 0 insertions, 0 deletions