diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2023-01-27 00:00:57 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-02-15 21:38:53 +0300 |
| commit | f88fd6504329ca8de0a04b6214e932c46746800d (patch) | |
| tree | fbde5225e618d6b02e106be9815ddb6281e8f9bd /fs/btrfs | |
| parent | c4e54a65711688e78e81d6e2720f19f0747eb176 (diff) | |
| download | linux-f88fd6504329ca8de0a04b6214e932c46746800d.tar.xz | |
btrfs: do not increment dirty_metadata_bytes in set_btree_ioerr
We only add if we set the extent buffer dirty, and we subtract when we
clear the extent buffer dirty. If we end up in set_btree_ioerr we have
already cleared the buffer dirty, and we aren't resetting dirty on the
extent buffer, so this is simply wrong.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/extent_io.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index e2816b86311a..ada88ada49e1 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -1912,13 +1912,6 @@ static void set_btree_ioerr(struct page *page, struct extent_buffer *eb) mapping_set_error(page->mapping, -EIO); /* - * If we error out, we should add back the dirty_metadata_bytes - * to make it consistent. - */ - percpu_counter_add_batch(&fs_info->dirty_metadata_bytes, - eb->len, fs_info->dirty_metadata_batch); - - /* * If writeback for a btree extent that doesn't belong to a log tree * failed, increment the counter transaction->eb_write_errors. * We do this because while the transaction is running and before it's |