diff options
| author | Steve French <stfrench@microsoft.com> | 2021-11-10 12:15:29 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-11-12 22:10:33 +0300 |
| commit | 02102744d364c1bca4a0da13c2a72656037f64eb (patch) | |
| tree | c57ab72b0244ee414fdf404761ed4f2d15cbc269 /fs/cifs/fscache.c | |
| parent | 7f28af9cf542f61758b982f8304f951ca99c8f58 (diff) | |
| download | linux-02102744d364c1bca4a0da13c2a72656037f64eb.tar.xz | |
smb3: do not setup the fscache_super_cookie until fsinfo initialized
We were calling cifs_fscache_get_super_cookie after tcon but before
we queried the info (QFS_Info) we need to initialize the cookie
properly. Also includes an additional check suggested by Paulo
to make sure we don't initialize super cookie twice.
Suggested-by: David Howells <dhowells@redhat.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/fscache.c')
| -rw-r--r-- | fs/cifs/fscache.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/cifs/fscache.c b/fs/cifs/fscache.c index 8eedd20c44ab..7e409a38a2d7 100644 --- a/fs/cifs/fscache.c +++ b/fs/cifs/fscache.c @@ -87,6 +87,14 @@ void cifs_fscache_get_super_cookie(struct cifs_tcon *tcon) char *sharename; struct cifs_fscache_super_auxdata auxdata; + /* + * Check if cookie was already initialized so don't reinitialize it. + * In the future, as we integrate with newer fscache features, + * we may want to instead add a check if cookie has changed + */ + if (tcon->fscache == NULL) + return; + sharename = extract_sharename(tcon->treeName); if (IS_ERR(sharename)) { cifs_dbg(FYI, "%s: couldn't extract sharename\n", __func__); |