summaryrefslogtreecommitdiff
path: root/fs/configfs
diff options
context:
space:
mode:
authorEric Sesterhenn <snakebyte@gmx.de>2006-03-23 02:36:54 +0300
committerMark Fasheh <mark.fasheh@oracle.com>2006-04-10 22:16:17 +0400
commitcbca692c246874a3cc1b5a9b694add4c39e8bc18 (patch)
treefd9ac8ed8387c72f444c7c78e57a1ff07427f0fb /fs/configfs
parenta9e2ae39170d01937725e1fff2e606baaa71346c (diff)
downloadlinux-cbca692c246874a3cc1b5a9b694add4c39e8bc18.tar.xz
[PATCH] Bogus NULL pointer check in fs/configfs/dir.c
We check the "group" pointer after we dereference it. This check is bogus, as it cannot be NULL coming in. Signed-off-by: Joel Becker <joel.becker@oracle.com> Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
Diffstat (limited to 'fs/configfs')
-rw-r--r--fs/configfs/dir.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index 8ed9b06a9828..5638c8f9362f 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -504,7 +504,7 @@ static int populate_groups(struct config_group *group)
int ret = 0;
int i;
- if (group && group->default_groups) {
+ if (group->default_groups) {
/* FYI, we're faking mkdir here
* I'm not sure we need this semaphore, as we're called
* from our parent's mkdir. That holds our parent's