summaryrefslogtreecommitdiff
path: root/fs/dcache.c
diff options
context:
space:
mode:
authorPaul Mackerras <paulus@samba.org>2014-11-13 12:15:23 +0300
committerAl Viro <viro@zeniv.linux.org.uk>2014-11-13 21:28:55 +0300
commitad0eab9293485d1c06237e9249f6d4dfa3d93d4d (patch)
treed0153dd69d25cfa259bdadd8b17f79e4d5be7ec5 /fs/dcache.c
parent7e8631e8b9d4e9f698c09c7e7309c96249180ff9 (diff)
downloadlinux-ad0eab9293485d1c06237e9249f6d4dfa3d93d4d.tar.xz
Fix thinko in iov_iter_single_seg_count
The branches of the if (i->type & ITER_BVEC) statement in iov_iter_single_seg_count() are the wrong way around; if ITER_BVEC is clear then we use i->bvec, when we should be using i->iov. This fixes it. In my case, the symptom that this caused was that a KVM guest doing filesystem operations on a virtual disk would result in one of qemu's threads on the host going into an infinite loop in generic_perform_write(). The loop would hit the copied == 0 case and call iov_iter_single_seg_count() to reduce the number of bytes to try to process, but because of the error, iov_iter_single_seg_count() would just return i->count and the loop made no progress and continued forever. Cc: stable@vger.kernel.org # 3.16+ Signed-off-by: Paul Mackerras <paulus@samba.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/dcache.c')
0 files changed, 0 insertions, 0 deletions