diff options
| author | Fabio M. De Francesco <fmdefrancesco@gmail.com> | 2023-06-14 13:02:55 +0300 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2023-06-15 05:24:05 +0300 |
| commit | f451fd97dd2b78f286379203a47d9d295c467255 (patch) | |
| tree | a3ae89923b1d97092fe2c6936d207f9498da6e21 /fs/ext4/ext4.h | |
| parent | 19482792113fa1dc419f9bc7b04b9dbdaa5256fd (diff) | |
| download | linux-f451fd97dd2b78f286379203a47d9d295c467255.tar.xz | |
ext4: drop the call to ext4_error() from ext4_get_group_info()
A recent patch added a call to ext4_error() which is problematic since
some callers of the ext4_get_group_info() function may be holding a
spinlock, whereas ext4_error() must never be called in atomic context.
This triggered a report from Syzbot: "BUG: sleeping function called from
invalid context in ext4_update_super" (see the link below).
Therefore, drop the call to ext4_error() from ext4_get_group_info(). In
the meantime use eight characters tabs instead of nine characters ones.
Reported-by: syzbot+4acc7d910e617b360859@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/00000000000070575805fdc6cdb2@google.com/
Fixes: 5354b2af3406 ("ext4: allow ext4_get_group_info() to fail")
Suggested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Link: https://lore.kernel.org/r/20230614100446.14337-1-fmdefrancesco@gmail.com
Diffstat (limited to 'fs/ext4/ext4.h')
0 files changed, 0 insertions, 0 deletions