summaryrefslogtreecommitdiff
path: root/fs/f2fs/Kconfig
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk.kim@samsung.com>2012-11-30 12:32:08 +0400
committerJaegeuk Kim <jaegeuk.kim@samsung.com>2012-12-11 08:43:43 +0400
commit573ea5fcf0a65fea4811f82edd6dc6045c04edda (patch)
tree8c2e5cfcd8cb2d868422d90a49b86a5c49d7da91 /fs/f2fs/Kconfig
parent0a8165d7c2cf1395059db20ab07665baf3758fcd (diff)
downloadlinux-573ea5fcf0a65fea4811f82edd6dc6045c04edda.tar.xz
f2fs: resolve build failures
There exist two build failures reported by Randy Dunlap as follows. (on i386) a. (config-r8857) ERROR: "f2fs_xattr_advise_handler" [fs/f2fs/f2fs.ko] undefined! Key configs in (config-r8857) are as follows. CONFIG_F2FS_FS=m # CONFIG_F2FS_STAT_FS is not set CONFIG_F2FS_FS_XATTR=y # CONFIG_F2FS_FS_POSIX_ACL is not set The error was occurred due to the function location that we made a mistake. Recently we added a new functionality for users to indicate cold files explicitly through xattr operations (i.e., f2fs_xattr_advise_handler). This handler should have been added in xattr.c instead of acl.c in order to avoid an undefined operation like in this case where XATTR is set and ACL is not set. b. (config-r8855) fs/f2fs/file.c: In function 'f2fs_vm_page_mkwrite': fs/f2fs/file.c:97:2: error: implicit declaration of function 'block_page_mkwrite_return' Key config in (config-r8855) is CONFIG_BLOCK. Obviously, f2fs works on top of the block device so that we should consider carefully a sort of config dependencies. The reason why this error was occurred was that f2fs_vm_page_mkwrite() calls block_page_mkwrite_return() which is enalbed only if CONFIG_BLOCK is set. Reported-by: Randy Dunlap <rdunlap@xenotime.net> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com> Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Diffstat (limited to 'fs/f2fs/Kconfig')
-rw-r--r--fs/f2fs/Kconfig1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/f2fs/Kconfig b/fs/f2fs/Kconfig
index 37a6b8e9438f..fd27e7e6326e 100644
--- a/fs/f2fs/Kconfig
+++ b/fs/f2fs/Kconfig
@@ -1,5 +1,6 @@
config F2FS_FS
tristate "F2FS filesystem support (EXPERIMENTAL)"
+ depends on BLOCK
help
F2FS is based on Log-structured File System (LFS), which supports
versatile "flash-friendly" features. The design has been focused on