summaryrefslogtreecommitdiff
path: root/fs/fuse/cuse.c
diff options
context:
space:
mode:
authorVivek Goyal <vgoyal@redhat.com>2019-03-07 00:51:40 +0300
committerMiklos Szeredi <mszeredi@redhat.com>2019-09-12 15:59:41 +0300
commit0cd1eb9a4160a96e0ec9b93b2e7b489f449bf22d (patch)
tree54ff7b7366dafb376d6a94bed28a86358c6b2023 /fs/fuse/cuse.c
parentae3aad77f46fbba56eff7141b2fc49870b60827e (diff)
downloadlinux-0cd1eb9a4160a96e0ec9b93b2e7b489f449bf22d.tar.xz
fuse: separate fuse device allocation and installation in fuse_conn
As of now fuse_dev_alloc() both allocates a fuse device and installs it in fuse_conn list. fuse_dev_alloc() can fail if fuse_device allocation fails. virtio-fs needs to initialize multiple fuse devices (one per virtio queue). It initializes one fuse device as part of call to fuse_fill_super_common() and rest of the devices are allocated and installed after that. But, we can't afford to fail after calling fuse_fill_super_common() as we don't have a way to undo all the actions done by fuse_fill_super_common(). So to avoid failures after the call to fuse_fill_super_common(), pre-allocate all fuse devices early and install them into fuse connection later. This patch provides two separate helpers for fuse device allocation and fuse device installation in fuse_conn. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/fuse/cuse.c')
-rw-r--r--fs/fuse/cuse.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fuse/cuse.c b/fs/fuse/cuse.c
index 6a0de0ce4403..45762bb7a934 100644
--- a/fs/fuse/cuse.c
+++ b/fs/fuse/cuse.c
@@ -508,7 +508,7 @@ static int cuse_channel_open(struct inode *inode, struct file *file)
*/
fuse_conn_init(&cc->fc, file->f_cred->user_ns, &fuse_dev_fiq_ops, NULL);
- fud = fuse_dev_alloc(&cc->fc);
+ fud = fuse_dev_alloc_install(&cc->fc);
if (!fud) {
kfree(cc);
return -ENOMEM;