summaryrefslogtreecommitdiff
path: root/fs/gfs2/incore.h
diff options
context:
space:
mode:
authorAlexander Aring <aahringo@redhat.com>2020-11-23 02:10:24 +0300
committerAndreas Gruenbacher <agruenba@redhat.com>2020-11-25 01:45:58 +0300
commit16e6281b6b22b0178eab95c6a82502d7b10f67b8 (patch)
tree48ca6ba8ee370a7c40b7a5e99d84c394341d39a0 /fs/gfs2/incore.h
parent418baf2c28f3473039f2f7377760bd8f6897ae18 (diff)
downloadlinux-16e6281b6b22b0178eab95c6a82502d7b10f67b8.tar.xz
gfs2: Fix deadlock dumping resource group glocks
Commit 0e539ca1bbbe ("gfs2: Fix NULL pointer dereference in gfs2_rgrp_dump") introduced additional locking in gfs2_rgrp_go_dump, which is also used for dumping resource group glocks via debugfs. However, on that code path, the glock spin lock is already taken in dump_glock, and taking it again in gfs2_glock2rgrp leads to deadlock. This can be reproduced with: $ mkfs.gfs2 -O -p lock_nolock /dev/FOO $ mount /dev/FOO /mnt/foo $ touch /mnt/foo/bar $ cat /sys/kernel/debug/gfs2/FOO/glocks Fix that by not taking the glock spin lock inside the go_dump callback. Fixes: 0e539ca1bbbe ("gfs2: Fix NULL pointer dereference in gfs2_rgrp_dump") Signed-off-by: Alexander Aring <aahringo@redhat.com> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/gfs2/incore.h')
0 files changed, 0 insertions, 0 deletions