diff options
author | Julia Lawall <julia@diku.dk> | 2008-03-24 21:08:48 +0300 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2008-03-31 13:41:46 +0400 |
commit | 773adff8e983cba1f5844c3be3be224ca6645f26 (patch) | |
tree | 369f9a4394176b0a8860e9558852d63453ccc9a4 /fs/gfs2/log.c | |
parent | 58e9fee13e579df44922172dbe3c9e3ba3edf7a3 (diff) | |
download | linux-773adff8e983cba1f5844c3be3be224ca6645f26.tar.xz |
[GFS2] test for IS_ERR rather than 0
The function gfs2_inode_lookup always returns either a valid pointer or a
value made with ERR_PTR, so its result should be tested with IS_ERR, not
with a test for 0.
The problem was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)
//<smpl>
@a@
expression E, E1;
statement S,S1;
position p;
@@
E = gfs2_inode_lookup(...)
... when != E = E1
if@p (E) S else S1
@n@
position a.p;
expression E,E1;
statement S,S1;
@@
E = NULL
... when != E = E1
if@p (E) S else S1
@depends on !n@
expression E;
statement S,S1;
position a.p;
@@
* if@p (E)
S else S1
//</smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/log.c')
0 files changed, 0 insertions, 0 deletions