diff options
| author | Pavel Begunkov <asml.silence@gmail.com> | 2021-03-14 23:57:08 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-04-07 16:00:05 +0300 |
| commit | 861fc287e03614695ddc95a752c2476c512ac8b3 (patch) | |
| tree | 2cacfeda0b773a720f36036f5ba30cbb461006dc /fs/io_uring.c | |
| parent | e1f8c95c1110ab8f9945269f4b23cfb0e49c5d6d (diff) | |
| download | linux-861fc287e03614695ddc95a752c2476c512ac8b3.tar.xz | |
io_uring: fix ->flags races by linked timeouts
[ Upstream commit efe814a471e0e58f28f1efaf430c8784a4f36626 ]
It's racy to modify req->flags from a not owning context, e.g. linked
timeout calling req_set_fail_links() for the master request might race
with that request setting/clearing flags while being executed
concurrently. Just remove req_set_fail_links(prev) from
io_link_timeout_fn(), io_async_find_and_cancel() and functions down the
line take care of setting the fail bit.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/io_uring.c')
| -rw-r--r-- | fs/io_uring.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index dde290eb7dd0..4e53445db73f 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -6242,7 +6242,6 @@ static enum hrtimer_restart io_link_timeout_fn(struct hrtimer *timer) spin_unlock_irqrestore(&ctx->completion_lock, flags); if (prev) { - req_set_fail_links(prev); io_async_find_and_cancel(ctx, req, prev->user_data, -ETIME); io_put_req_deferred(prev, 1); } else { |