diff options
author | NeilBrown <neilb@suse.com> | 2015-07-30 06:00:56 +0300 |
---|---|---|
committer | Sasha Levin <sasha.levin@oracle.com> | 2015-10-07 17:17:09 +0300 |
commit | 47bd9168e93703d8ab8104a9d0b858a9cb2dd9c3 (patch) | |
tree | aa84542f77b7a52d351fc891b67914c033a166ef /fs/nfs/pnfs.h | |
parent | 04b4d54f032051de6259e859677d4712516eece3 (diff) | |
download | linux-47bd9168e93703d8ab8104a9d0b858a9cb2dd9c3.tar.xz |
NFSv4: don't set SETATTR for O_RDONLY|O_EXCL
[ Upstream commit efcbc04e16dfa95fef76309f89710dd1d99a5453 ]
It is unusual to combine the open flags O_RDONLY and O_EXCL, but
it appears that libre-office does just that.
[pid 3250] stat("/home/USER/.config", {st_mode=S_IFDIR|0700, st_size=8192, ...}) = 0
[pid 3250] open("/home/USER/.config/libreoffice/4-suse/user/extensions/buildid", O_RDONLY|O_EXCL <unfinished ...>
NFSv4 takes O_EXCL as a sign that a setattr command should be sent,
probably to reset the timestamps.
When it was an O_RDONLY open, the SETATTR command does not
identify any actual attributes to change.
If no delegation was provided to the open, the SETATTR uses the
all-zeros stateid and the request is accepted (at least by the
Linux NFS server - no harm, no foul).
If a read-delegation was provided, this is used in the SETATTR
request, and a Netapp filer will justifiably claim
NFS4ERR_BAD_STATEID, which the Linux client takes as a sign
to retry - indefinitely.
So only treat O_EXCL specially if O_CREAT was also given.
Signed-off-by: NeilBrown <neilb@suse.com>
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'fs/nfs/pnfs.h')
0 files changed, 0 insertions, 0 deletions