diff options
| author | Maurizio Lombardi <mlombard@redhat.com> | 2021-07-02 11:11:21 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-07-20 17:05:53 +0300 |
| commit | 89047f0089cd7430e4896fb99ba0f17ade832433 (patch) | |
| tree | 16703d5fa48e470d32df5b496f0f528f0ebb00f0 /fs/nfsd | |
| parent | 4b3fd33f580fe10691b99ef0b1356b9f3607b015 (diff) | |
| download | linux-89047f0089cd7430e4896fb99ba0f17ade832433.tar.xz | |
nvme-tcp: can't set sk_user_data without write_lock
[ Upstream commit 0755d3be2d9bb6ea38598ccd30d6bbaa1a5c3a50 ]
The sk_user_data pointer is supposed to be modified only while
holding the write_lock "sk_callback_lock", otherwise
we could race with other threads and crash the kernel.
we can't take the write_lock in nvmet_tcp_state_change()
because it would cause a deadlock, but the release_work queue
will set the pointer to NULL later so we can simply remove
the assignment.
Fixes: b5332a9f3f3d ("nvmet-tcp: fix incorrect locking in state_change sk callback")
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/nfsd')
0 files changed, 0 insertions, 0 deletions