diff options
| author | Steve French <stfrench@microsoft.com> | 2024-04-25 19:30:16 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-05-02 17:32:44 +0300 |
| commit | 0fcf7e219448e937681216353c9a58abae6d3c2e (patch) | |
| tree | 42f9eb7952718a1181a26b5bea2913441dbe61da /fs/smb/client/transport.c | |
| parent | 39ad3d61d23e099a93687f63eeb5a8402e0f7be8 (diff) | |
| download | linux-0fcf7e219448e937681216353c9a58abae6d3c2e.tar.xz | |
smb3: missing lock when picking channel
commit 8094a600245e9b28eb36a13036f202ad67c1f887 upstream.
Coverity spotted a place where we should have been holding the
channel lock when accessing the ses channel index.
Addresses-Coverity: 1582039 ("Data race condition (MISSING_LOCK)")
Cc: stable@vger.kernel.org
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/smb/client/transport.c')
| -rw-r--r-- | fs/smb/client/transport.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/smb/client/transport.c b/fs/smb/client/transport.c index 994d70193432..e1a79e031b28 100644 --- a/fs/smb/client/transport.c +++ b/fs/smb/client/transport.c @@ -1057,9 +1057,11 @@ struct TCP_Server_Info *cifs_pick_channel(struct cifs_ses *ses) index = (uint)atomic_inc_return(&ses->chan_seq); index %= ses->chan_count; } + + server = ses->chans[index].server; spin_unlock(&ses->chan_lock); - return ses->chans[index].server; + return server; } int |