diff options
| author | Ian Abbott <abbotti@mev.co.uk> | 2021-09-16 17:50:23 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-21 18:53:54 +0300 |
| commit | bb509a6ffed2c8b0950f637ab5779aa818ed1596 (patch) | |
| tree | c64d71aa16feaabeb7dfaee3dcaf84432e869ba1 /fs/tracefs | |
| parent | 7af526c740bdbd5b4dcebba04ace5b3b0c07801f (diff) | |
| download | linux-bb509a6ffed2c8b0950f637ab5779aa818ed1596.tar.xz | |
comedi: Fix memory leak in compat_insnlist()
`compat_insnlist()` handles the 32-bit version of the `COMEDI_INSNLIST`
ioctl (whenwhen `CONFIG_COMPAT` is enabled). It allocates memory to
temporarily hold an array of `struct comedi_insn` converted from the
32-bit version in user space. This memory is only being freed if there
is a fault while filling the array, otherwise it is leaked.
Add a call to `kfree()` to fix the leak.
Fixes: b8d47d881305 ("comedi: get rid of compat_alloc_user_space() mess in COMEDI_INSNLIST compat")
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev
Cc: <stable@vger.kernel.org> # 5.13+
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20210916145023.157479-1-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/tracefs')
0 files changed, 0 insertions, 0 deletions