diff options
author | Wang YanQing <udknight@gmail.com> | 2023-03-28 18:35:34 +0300 |
---|---|---|
committer | Richard Weinberger <richard@nod.at> | 2023-04-21 23:31:15 +0300 |
commit | 31a149d5c13c4cbcf97de3435817263a2d8c9d6e (patch) | |
tree | f9193d2a00317bbf55902e5e0ec93cf32f5899c1 /fs/ubifs/dir.c | |
parent | c477d83c26b7acd526a30a32be7e9c0bab5da285 (diff) | |
download | linux-31a149d5c13c4cbcf97de3435817263a2d8c9d6e.tar.xz |
ubi: Fix return value overwrite issue in try_write_vid_and_data()
The commit 2d78aee426d8 ("UBI: simplify LEB write and atomic LEB change code")
adds helper function, try_write_vid_and_data(), to simplify the code, but this
helper function has bug, it will return 0 (success) when ubi_io_write_vid_hdr()
or the ubi_io_write_data() return error number (-EIO, etc), because the return
value of ubi_wl_put_peb() will overwrite the original return value.
This issue will cause unexpected data loss issue, because the caller of this
function and UBIFS willn't know the data is lost.
Fixes: 2d78aee426d8 ("UBI: simplify LEB write and atomic LEB change code")
Cc: stable@vger.kernel.org
Signed-off-by: Wang YanQing <udknight@gmail.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'fs/ubifs/dir.c')
0 files changed, 0 insertions, 0 deletions