diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2022-10-29 01:48:58 +0300 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2022-10-31 18:58:20 +0300 |
| commit | b65e08f83b119ae9345ed23d4da357a72b3cb55c (patch) | |
| tree | 5c25440a24f3ed77d51f8401412b939e20f6a8fb /fs/xfs/libxfs/xfs_rmap.c | |
| parent | f850995f60e49818093ef5e477cdb0ff2c11a0a4 (diff) | |
| download | linux-b65e08f83b119ae9345ed23d4da357a72b3cb55c.tar.xz | |
xfs: create a predicate to verify per-AG extents
Create a predicate function to verify that a given agbno/blockcount pair
fit entirely within a single allocation group and don't suffer
mathematical overflows. Refactor the existng open-coded logic; we're
going to add more calls to this function in the next patch.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to 'fs/xfs/libxfs/xfs_rmap.c')
| -rw-r--r-- | fs/xfs/libxfs/xfs_rmap.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/fs/xfs/libxfs/xfs_rmap.c b/fs/xfs/libxfs/xfs_rmap.c index 094dfc897ebc..b56aca1e7c66 100644 --- a/fs/xfs/libxfs/xfs_rmap.c +++ b/fs/xfs/libxfs/xfs_rmap.c @@ -235,13 +235,8 @@ xfs_rmap_get_rec( goto out_bad_rec; } else { /* check for valid extent range, including overflow */ - if (!xfs_verify_agbno(pag, irec->rm_startblock)) - goto out_bad_rec; - if (irec->rm_startblock > - irec->rm_startblock + irec->rm_blockcount) - goto out_bad_rec; - if (!xfs_verify_agbno(pag, - irec->rm_startblock + irec->rm_blockcount - 1)) + if (!xfs_verify_agbext(pag, irec->rm_startblock, + irec->rm_blockcount)) goto out_bad_rec; } |