diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2024-04-22 19:47:22 +0300 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2024-04-23 17:46:51 +0300 |
| commit | c27411d4c640037d70e2fa5751616e175e52ca5e (patch) | |
| tree | dd25c9f1b8a510a12c98f9ceb2611d7204947cd5 /fs/xfs/xfs_iops.c | |
| parent | 54275d8496f3e4764302cebc0e9517d950ba6589 (diff) | |
| download | linux-c27411d4c640037d70e2fa5751616e175e52ca5e.tar.xz | |
xfs: make attr removal an explicit operation
Parent pointers match attrs on name+value, unlike everything else which
matches on only the name. Therefore, we cannot keep using the heuristic
that !value means remove. Make this an explicit operation code.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/xfs_iops.c')
| -rw-r--r-- | fs/xfs/xfs_iops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index d02ca2248bbc..659fd10c0cda 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -63,7 +63,7 @@ xfs_initxattrs( .value = xattr->value, .valuelen = xattr->value_len, }; - error = xfs_attr_change(&args, XFS_ATTRUPDATE_UPSERTR); + error = xfs_attr_change(&args, XFS_ATTRUPDATE_UPSERT); if (error < 0) break; } |