diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2023-10-16 19:21:37 +0300 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2023-10-18 02:23:49 +0300 |
| commit | ddd98076d5c075c8a6c49d9e6e8ee12844137f23 (patch) | |
| tree | a04e2497efad7a430cc574e32d98f92538c7fbae /fs/xfs | |
| parent | c2988eb5cff75c02bc57e02c323154aa08f55b78 (diff) | |
| download | linux-ddd98076d5c075c8a6c49d9e6e8ee12844137f23.tar.xz | |
xfs: fix units conversion error in xfs_bmap_del_extent_delay
The unit conversions in this function do not make sense. First we
convert a block count to bytes, then divide that bytes value by
rextsize, which is in blocks, to get an rt extent count. You can't
divide bytes by blocks to get a (possibly multiblock) extent value.
Fortunately nobody uses delalloc on the rt volume so this hasn't
mattered.
Fixes: fa5c836ca8eb5 ("xfs: refactor xfs_bunmapi_cow")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/libxfs/xfs_bmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c index 26bfa34b4bbf..617cc7e78e38 100644 --- a/fs/xfs/libxfs/xfs_bmap.c +++ b/fs/xfs/libxfs/xfs_bmap.c @@ -4827,7 +4827,7 @@ xfs_bmap_del_extent_delay( ASSERT(got_endoff >= del_endoff); if (isrt) { - uint64_t rtexts = XFS_FSB_TO_B(mp, del->br_blockcount); + uint64_t rtexts = del->br_blockcount; do_div(rtexts, mp->m_sb.sb_rextsize); xfs_mod_frextents(mp, rtexts); |