diff options
| author | Martin Brandenburg <martin@omnibond.com> | 2017-04-25 22:38:04 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-20 15:31:00 +0300 |
| commit | 49302d5313252a62622b942b35b2bf7538c5bbb0 (patch) | |
| tree | beaf129f8ae4865fd969f0fdf7690660eff48560 /fs | |
| parent | 42d86d92af64e041adb999da74acad54f14d29cb (diff) | |
| download | linux-49302d5313252a62622b942b35b2bf7538c5bbb0.tar.xz | |
orangefs: do not check possibly stale size on truncate
commit 53950ef541675df48c219a8d665111a0e68dfc2f upstream.
Let the server figure this out because our size might be out of date or
not present.
The bug was that
xfs_io -f -t -c "pread -v 0 100" /mnt/foo
echo "Test" > /mnt/foo
xfs_io -f -t -c "pread -v 0 100" /mnt/foo
fails because the second truncate did not happen if nothing had
requested the size after the write in echo. Thus i_size was zero (not
present) and the orangefs_setattr though i_size was zero and there was
nothing to do.
Signed-off-by: Martin Brandenburg <martin@omnibond.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/orangefs/inode.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c index 551bc74ed2b8..fdf520f43f2e 100644 --- a/fs/orangefs/inode.c +++ b/fs/orangefs/inode.c @@ -224,8 +224,7 @@ int orangefs_setattr(struct dentry *dentry, struct iattr *iattr) if (ret) goto out; - if ((iattr->ia_valid & ATTR_SIZE) && - iattr->ia_size != i_size_read(inode)) { + if (iattr->ia_valid & ATTR_SIZE) { ret = orangefs_setattr_size(inode, iattr); if (ret) goto out; |