diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2023-09-18 17:34:51 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-09-20 21:44:40 +0300 |
| commit | 58bfe2ccec5f9f137b41dd38f335290dcc13cd5c (patch) | |
| tree | d210b6d37c439896b2fa682708fdd629544e78c7 /fs | |
| parent | 8ec0a4a5774ab3f91c356c71f24dfba615bee860 (diff) | |
| download | linux-58bfe2ccec5f9f137b41dd38f335290dcc13cd5c.tar.xz | |
btrfs: properly report 0 avail for very full file systems
A user reported some issues with smaller file systems that get very
full. While investigating this issue I noticed that df wasn't showing
100% full, despite having 0 chunk space and having < 1MiB of available
metadata space.
This turns out to be an overflow issue, we're doing:
total_available_metadata_space - SZ_4M < global_block_rsv_size
to determine if there's not enough space to make metadata allocations,
which overflows if total_available_metadata_space is < 4M. Fix this by
checking to see if our available space is greater than the 4M threshold.
This makes df properly report 100% usage on the file system.
CC: stable@vger.kernel.org # 4.14+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index cffdd6f7f8e8..1a093ec0f7e3 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -2117,7 +2117,7 @@ static int btrfs_statfs(struct dentry *dentry, struct kstatfs *buf) * calculated f_bavail. */ if (!mixed && block_rsv->space_info->full && - total_free_meta - thresh < block_rsv->size) + (total_free_meta < thresh || total_free_meta - thresh < block_rsv->size)) buf->f_bavail = 0; buf->f_type = BTRFS_SUPER_MAGIC; |