diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2019-10-25 07:03:11 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-21 12:34:21 +0300 |
commit | 80e1d36be85259400291976aed03e924f28f8997 (patch) | |
tree | b410c300fcd138a8333d6d789360ab6375564abb /fs | |
parent | 3bc62e2e3faca8753303e845b9868f8e278e2471 (diff) | |
download | linux-80e1d36be85259400291976aed03e924f28f8997.tar.xz |
autofs: fix a leak in autofs_expire_indirect()
[ Upstream commit 03ad0d703df75c43f78bd72e16124b5b94a95188 ]
if the second call of should_expire() in there ends up
grabbing and returning a new reference to dentry, we need
to drop it before continuing.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/autofs4/expire.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c index 0d8b9c4f27f2..5124f06c32bc 100644 --- a/fs/autofs4/expire.c +++ b/fs/autofs4/expire.c @@ -467,9 +467,10 @@ struct dentry *autofs4_expire_indirect(struct super_block *sb, */ flags &= ~AUTOFS_EXP_LEAVES; found = should_expire(expired, mnt, timeout, how); - if (!found || found != expired) - /* Something has changed, continue */ + if (found != expired) { // something has changed, continue + dput(found); goto next; + } if (expired != dentry) dput(dentry); |