diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2023-05-12 11:05:41 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-05-27 04:27:46 +0300 |
| commit | 48b47f0caaa8a9f05ed803cb4f335fa3a7bfc622 (patch) | |
| tree | 4a4fb2965d22021146ac38b26771e1c520090117 /fs | |
| parent | 0d85b27b0cc6b5cf54567c5ad913a247a71583ce (diff) | |
| download | linux-48b47f0caaa8a9f05ed803cb4f335fa3a7bfc622.tar.xz | |
ksmbd: fix uninitialized pointer read in ksmbd_vfs_rename()
Uninitialized rd.delegated_inode can be used in vfs_rename().
Fix this by setting rd.delegated_inode to NULL to avoid the uninitialized
read.
Fixes: 74d7970febf7 ("ksmbd: fix racy issue from using ->d_parent and ->d_name")
Reported-by: Coverity Scan <scan-admin@coverity.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/smb/server/vfs.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c index 778c152708e4..9bdb01c5b201 100644 --- a/fs/smb/server/vfs.c +++ b/fs/smb/server/vfs.c @@ -743,6 +743,7 @@ retry: rd.new_dir = new_path.dentry->d_inode, rd.new_dentry = new_dentry, rd.flags = flags, + rd.delegated_inode = NULL, err = vfs_rename(&rd); if (err) ksmbd_debug(VFS, "vfs_rename failed err %d\n", err); |