summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorMiklos Szeredi <mszeredi@redhat.com>2024-05-02 21:35:57 +0300
committerMiklos Szeredi <mszeredi@redhat.com>2024-05-02 21:35:57 +0300
commit096802748ea1dea8b476938e0a8dc16f4bd2f1ad (patch)
tree6c4e0f19663a58f7f0ca17bb01ceeec89e81f0f4 /fs
parent9a87907de3597a339cc129229d1a20bc7365ea5f (diff)
downloadlinux-096802748ea1dea8b476938e0a8dc16f4bd2f1ad.tar.xz
ovl: remove upper umask handling from ovl_create_upper()
This is already done by vfs_prepare_mode() when creating the upper object by vfs_create(), vfs_mkdir() and vfs_mknod(). No regressions have been observed in xfstests run with posix acls turned off for the upper filesystem. Fixes: 1639a49ccdce ("fs: move S_ISGID stripping into the vfs_*() helpers") Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/overlayfs/dir.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
index c614e923b143..116f542442dd 100644
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -330,9 +330,6 @@ static int ovl_create_upper(struct dentry *dentry, struct inode *inode,
struct dentry *newdentry;
int err;
- if (!attr->hardlink && !IS_POSIXACL(udir))
- attr->mode &= ~current_umask();
-
inode_lock_nested(udir, I_MUTEX_PARENT);
newdentry = ovl_create_real(ofs, udir,
ovl_lookup_upper(ofs, dentry->d_name.name,