summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorCsaba Henk <csaba@gluster.com>2009-11-27 17:00:14 +0300
committerMiklos Szeredi <mszeredi@suse.cz>2009-11-27 18:37:13 +0300
commit1b7323965a8c6eee9dc4e345a7ae4bff1dc93149 (patch)
treee0f6708e1bb274a2204919dbcc698be5f5880f0c /fs
parenta8a8a669ea13d792296737505adc43ccacf3a648 (diff)
downloadlinux-1b7323965a8c6eee9dc4e345a7ae4bff1dc93149.tar.xz
fuse: reject O_DIRECT flag also in fuse_create
The comment in fuse_open about O_DIRECT: "VFS checks this, but only _after_ ->open()" also holds for fuse_create, however, the same kind of check was missing there. As an impact of this bug, open(newfile, O_RDWR|O_CREAT|O_DIRECT) fails, but a stub newfile will remain if the fuse server handled the implied FUSE_CREATE request appropriately. Other impact: in the above situation ima_file_free() will complain to open/free imbalance if CONFIG_IMA is set. Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Cc: Harshavardhana <harsha@gluster.com> Cc: stable@kernel.org
Diffstat (limited to 'fs')
-rw-r--r--fs/fuse/dir.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index 8ada78aade58..4787ae6c5c1c 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -385,6 +385,9 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry, int mode,
if (fc->no_create)
return -ENOSYS;
+ if (flags & O_DIRECT)
+ return -EINVAL;
+
forget_req = fuse_get_req(fc);
if (IS_ERR(forget_req))
return PTR_ERR(forget_req);