diff options
| author | Jerome Marchand <jmarchan@redhat.com> | 2016-01-16 03:54:48 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-02-20 01:28:38 +0300 |
| commit | b3143ec6ddea62344574cce2ebf2633eb1958727 (patch) | |
| tree | d4115fc8225921cdcb1a8664862a1137a7ea0ae0 /include/asm-generic/qspinlock.h | |
| parent | 5b243a2947d98973ba553af9a9b6858d3f59f62f (diff) | |
| download | linux-b3143ec6ddea62344574cce2ebf2633eb1958727.tar.xz | |
zram: don't call idr_remove() from zram_remove()
commit 17ec4cd985780a7e30aa45bb8f272237c12502a4 upstream.
The use of idr_remove() is forbidden in the callback functions of
idr_for_each(). It is therefore unsafe to call idr_remove in
zram_remove().
This patch moves the call to idr_remove() from zram_remove() to
hot_remove_store(). In the detroy_devices() path, idrs are removed by
idr_destroy(). This solves an use-after-free detected by KASan.
[akpm@linux-foundation.org: fix coding stype, per Sergey]
Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/asm-generic/qspinlock.h')
0 files changed, 0 insertions, 0 deletions