summaryrefslogtreecommitdiff
path: root/include/drm
diff options
context:
space:
mode:
authorEric Anholt <eric@anholt.net>2018-05-09 03:14:25 +0300
committerEric Anholt <eric@anholt.net>2018-05-14 09:43:09 +0300
commitc9ac371d4b5982d2f179d42bb99781e510d55f50 (patch)
treeef68b92d3a7f56a7eb15f63dfa667d093713931b /include/drm
parent94cc2fde365fb4484080ea6675bb1e0c933f8002 (diff)
downloadlinux-c9ac371d4b5982d2f179d42bb99781e510d55f50.tar.xz
drm: Fix render node numbering regression from control node removal.
drm_minor_alloc() does multiplication on this enum, so the removal ended up moving render nodes down from 128 base to 64. This caused Mesa's surfaceless backend to be unable to open the render nodes, since it was still looking up at 128. v2: Add a comment warning the next person. Signed-off-by: Eric Anholt <eric@anholt.net> Fixes: 0d49f303e8a7 ("drm: remove all control node code") Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20180509001425.12574-1-eric@anholt.net
Diffstat (limited to 'include/drm')
-rw-r--r--include/drm/drm_file.h4
1 files changed, 4 insertions, 0 deletions
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 91a65a360079..027ac16da3d1 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -47,8 +47,12 @@ struct device;
* header include loops we need it here for now.
*/
+/* Note that the order of this enum is ABI (it determines
+ * /dev/dri/renderD* numbers).
+ */
enum drm_minor_type {
DRM_MINOR_PRIMARY,
+ DRM_MINOR_CONTROL,
DRM_MINOR_RENDER,
};