diff options
| author | Mikhail Lappo <mikhail.lappo@esrlabs.com> | 2018-02-02 21:17:46 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-04-24 10:36:34 +0300 |
| commit | ecb67e92d42e1fbbb710c9c86259ba4ef0839304 (patch) | |
| tree | 5cde87eab6f344f36a6a5f62484c222914623e81 /include/dt-bindings | |
| parent | c9b200ce2be5da7613e73daf356bd0ae63c0a48d (diff) | |
| download | linux-ecb67e92d42e1fbbb710c9c86259ba4ef0839304.tar.xz | |
thermal: imx: Fix race condition in imx_thermal_probe()
commit cf1ba1d73a33944d8c1a75370a35434bf146b8a7 upstream.
When device boots with T > T_trip_1 and requests interrupt,
the race condition takes place. The interrupt comes before
THERMAL_DEVICE_ENABLED is set. This leads to an attempt to
reading sensor value from irq and disabling the sensor, based on
the data->mode field, which expected to be THERMAL_DEVICE_ENABLED,
but still stays as THERMAL_DEVICE_DISABLED. Afher this issue
sensor is never re-enabled, as the driver state is wrong.
Fix this problem by setting the 'data' members prior to
requesting the interrupts.
Fixes: 37713a1e8e4c ("thermal: imx: implement thermal alarm interrupt handling")
Cc: <stable@vger.kernel.org>
Signed-off-by: Mikhail Lappo <mikhail.lappo@esrlabs.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/dt-bindings')
0 files changed, 0 insertions, 0 deletions