summaryrefslogtreecommitdiff
path: root/include/linux/binfmts.h
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2017-07-19 01:25:30 +0300
committerKees Cook <keescook@chromium.org>2017-08-01 22:03:04 +0300
commita9208e42ba99bfe63bdf5f76aaf0193ad3805f02 (patch)
tree28a82e9295894afd8410a62a60936cc68eb8c756 /include/linux/binfmts.h
parentddb4a1442def2a78b91a85b4251fb712ef23662b (diff)
downloadlinux-a9208e42ba99bfe63bdf5f76aaf0193ad3805f02.tar.xz
exec: Correct comments about "point of no return"
In commit 221af7f87b97 ("Split 'flush_old_exec' into two functions"), the comment about the point of no return should have stayed in flush_old_exec() since it refers to "bprm->mm = NULL;" line, but prior changes in commits c89681ed7d0e ("remove steal_locks()"), and fd8328be874f ("sanitize handling of shared descriptor tables in failing execve()") made it look like it meant the current->sas_ss_sp line instead. The comment was referring to the fact that once bprm->mm is NULL, all failures from a binfmt load_binary hook (e.g. load_elf_binary), will get SEGV raised against current. Move this comment and expand the explanation a bit, putting it above the assignment this time, and add details about the true nature of "point of no return" being the call to flush_old_exec() itself. This also removes an erroneous commet about when credentials are being installed. That has its own dedicated function, install_exec_creds(), which carries a similar (and correct) comment, so remove the bogus comment where installation is not actually happening. Cc: David Howells <dhowells@redhat.com> Cc: Eric W. Biederman <ebiederm@xmission.com> Signed-off-by: Kees Cook <keescook@chromium.org> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com> Acked-by: Serge Hallyn <serge@hallyn.com>
Diffstat (limited to 'include/linux/binfmts.h')
0 files changed, 0 insertions, 0 deletions