summaryrefslogtreecommitdiff
path: root/include/linux/dirent.h
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2020-03-24 01:17:52 +0300
committerGustavo A. R. Silva <gustavo@embeddedor.com>2020-04-18 23:44:54 +0300
commita2008395fe2ebd9cd82f220d034d36cc887f35fe (patch)
tree325098cb3f214f3bf0c517d5fc584fdb5c19ba06 /include/linux/dirent.h
parent1fa0949bede6de2b595da535c3ce69de8e130db2 (diff)
downloadlinux-a2008395fe2ebd9cd82f220d034d36cc887f35fe.tar.xz
dirent.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Diffstat (limited to 'include/linux/dirent.h')
-rw-r--r--include/linux/dirent.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/dirent.h b/include/linux/dirent.h
index fc61f3cff72f..99002220cd45 100644
--- a/include/linux/dirent.h
+++ b/include/linux/dirent.h
@@ -7,7 +7,7 @@ struct linux_dirent64 {
s64 d_off;
unsigned short d_reclen;
unsigned char d_type;
- char d_name[0];
+ char d_name[];
};
#endif