summaryrefslogtreecommitdiff
path: root/include/linux/fsnotify.h
diff options
context:
space:
mode:
authorAmir Goldstein <amir73il@gmail.com>2019-05-26 17:34:11 +0300
committerJan Kara <jack@suse.cz>2019-06-20 15:47:54 +0300
commit7377f5bec13332bc470856f337935be6cabbcf24 (patch)
treeb2906da2c692ddddfcd63ba74c8ee1e1747ec508 /include/linux/fsnotify.h
parent49246466a98996e78b68a0041807dbd2628c53fe (diff)
downloadlinux-7377f5bec13332bc470856f337935be6cabbcf24.tar.xz
fsnotify: get rid of fsnotify_nameremove()
For all callers of fsnotify_{unlink,rmdir}(), we made sure that d_parent and d_name are stable. Therefore, fsnotify_{unlink,rmdir}() do not need the safety measures in fsnotify_nameremove() to stabilize parent and name. We can now simplify those hooks and get rid of fsnotify_nameremove(). Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'include/linux/fsnotify.h')
-rw-r--r--include/linux/fsnotify.h6
1 files changed, 2 insertions, 4 deletions
diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h
index 0145073c2b42..a2d5d175d3c1 100644
--- a/include/linux/fsnotify.h
+++ b/include/linux/fsnotify.h
@@ -198,8 +198,7 @@ static inline void fsnotify_unlink(struct inode *dir, struct dentry *dentry)
/* Expected to be called before d_delete() */
WARN_ON_ONCE(d_is_negative(dentry));
- /* TODO: call fsnotify_dirent() */
- fsnotify_nameremove(dentry, 0);
+ fsnotify_dirent(dir, dentry, FS_DELETE);
}
/*
@@ -222,8 +221,7 @@ static inline void fsnotify_rmdir(struct inode *dir, struct dentry *dentry)
/* Expected to be called before d_delete() */
WARN_ON_ONCE(d_is_negative(dentry));
- /* TODO: call fsnotify_dirent() */
- fsnotify_nameremove(dentry, 1);
+ fsnotify_dirent(dir, dentry, FS_DELETE | FS_ISDIR);
}
/*